Use a PAGE_STEP macro instead of a magic number
authorClaudio Saavedra <csaavedra@igalia.com>
Mon, 27 Jun 2011 16:58:21 +0000 (19:58 +0300)
committerClaudio Saavedra <csaavedra@igalia.com>
Tue, 28 Jun 2011 06:47:44 +0000 (09:47 +0300)
Helps to understand the code.

https://bugzilla.gnome.org/show_bug.cgi?id=653512

gtk/gtkentry.c

index 0e2d931b307e24540beaa294b88892c88e5c6fb2..8e1b7ec43c4bfaa695661d3828b825dc6c6f3776 100644 (file)
 #define DRAW_TIMEOUT     20
 #define COMPLETION_TIMEOUT 300
 #define PASSWORD_HINT_MAX 8
+#define PAGE_STEP 14
 
 #define MAX_ICONS 2
 
@@ -9591,13 +9592,13 @@ gtk_entry_completion_key_press (GtkWidget   *widget,
            completion->priv->current_selected = -1;
          else if (completion->priv->current_selected < matches) 
            {
-             completion->priv->current_selected -= 14;
+             completion->priv->current_selected -= PAGE_STEP;
              if (completion->priv->current_selected < 0)
                completion->priv->current_selected = 0;
            }
          else 
            {
-             completion->priv->current_selected -= 14;
+             completion->priv->current_selected -= PAGE_STEP;
              if (completion->priv->current_selected < matches - 1)
                completion->priv->current_selected = matches - 1;
            }
@@ -9608,7 +9609,7 @@ gtk_entry_completion_key_press (GtkWidget   *widget,
            completion->priv->current_selected = 0;
          else if (completion->priv->current_selected < matches - 1)
            {
-             completion->priv->current_selected += 14;
+             completion->priv->current_selected += PAGE_STEP;
              if (completion->priv->current_selected > matches - 1)
                completion->priv->current_selected = matches - 1;
            }
@@ -9618,7 +9619,7 @@ gtk_entry_completion_key_press (GtkWidget   *widget,
            }
          else
            {
-             completion->priv->current_selected += 14;
+             completion->priv->current_selected += PAGE_STEP;
              if (completion->priv->current_selected > matches + actions - 1)
                completion->priv->current_selected = matches + actions - 1;
            }